fix(blockrun): safely retry stale Solana blockhash - #720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solana x402 signatures include a server-provided recent blockhash. A signed retry can be rejected with
PAYMENT_INVALID/expired_signatureor stale blockhash errors. The previous adapter treated every second 402 as terminal, so recoverable stale challenges failed; blindly retrying every 402 would risk duplicate settlement.Scope and design
relay/channel/blockrun.SETTLEMENT_FAILED,insufficient_funds, ordinary 402 responses, or poll/settlement failures.Validation
go test ./relay/channel/blockrunpasses.go test ./relay/...reaches unrelated pre-existing failures in Claude/Codex packages; BlockRun packages pass.Deployment
This changes shared relay request handling for BlockRun Solana and therefore requires router deployment after review. No staging or production deployment was performed by this change.