harden: negative fixtures + M3 (schemas must reject malformed manifests)#8
Merged
Conversation
Add fixtures/invalid/ (bad function enum, mutable-carry safety violation, missing schemaVersion, invalid maturity level, empty owners) + run_negative_fixtures.py, wired into CI. A malformed manifest can no longer pass validation silently. Bump maturity M2->M3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M2 → M3 hardening. Adds negative fixtures the schemas MUST reject, so a malformed manifest can never validate silently, and enforces it in CI.
New
fixtures/invalid/:functional-service.bad-function.json—functionoutside the canonical enumfunctional-service.mutable-carry.json—sourceosCarry.carriesMutableModelState: true(the critical SourceOS safety invariant)functional-service.missing-schema-version.json— required field omittedmaturity.invalid-level.yaml— level outside M0–M5maturity.empty-owners.yaml— empty owners (violates minItems)tools/run_negative_fixtures.pyvalidates each against its schema and exits non-zero if any unexpectedly passes. Wired into CI (Negative fixtures (must be rejected)) andmake validate-negative.Bumps
repo.maturity.yamlto M3 (CI-hardened: negative fixtures + enforced CI), target M4.🤖 Generated with Claude Code