🛠️ fix(generator): fix copyWith and fromMap to respect constructor fields

[KiddoV]

Related issue: #26

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the datum_generator package where the generated copyWith and fromMap methods did not properly account for fields defined in the class constructor. The changes ensure that these methods are now generated correctly, only including and processing fields that are explicitly part of the constructor, thereby enhancing the robustness and correctness of the generated code.

Highlights

• Constructor Field Respect: The copyWith and fromMap methods generated by datum_generator now correctly identify and utilize only those fields that are explicitly part of the class's constructor.
• Improved Code Generation Logic: The generation logic for copyWith and fromMap has been refined to prevent the inclusion of fields that are not part of the constructor, addressing potential runtime errors or unexpected behavior.
• Dependency Update: The analyzer package's dart/element/element.dart was imported to facilitate the inspection of class constructors and their parameters.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request effectively addresses the issue where copyWith and fromMap methods did not correctly respect the constructor fields of a DatumSerializable class. By introducing logic to resolve the class constructor and filter fields based on whether they are formal parameters, the generated code now ensures that only relevant fields are included in these methods. This significantly improves the correctness and robustness of the generated code, preventing potential runtime errors when dealing with classes that have fields not present in their primary constructor. The changes are well-implemented and align with the stated goal of the pull request.

[KiddoV]

@Shreemanarjun Can you please have some time to check all of my PRs? Thanks!