add read tool formatters - #1016
Merged
Merged
Conversation
Contributor
Author
This was referenced Jul 2, 2026
Merged
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-read
branch
from
July 3, 2026 14:50
af63b1e to
1522547
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-bash
branch
from
July 3, 2026 14:50
d2b7c43 to
3ee55e7
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-read
branch
from
July 3, 2026 15:30
1522547 to
2162423
Compare
LasmarKhalifa
marked this pull request as ready for review
July 3, 2026 16:30
LasmarKhalifa
requested review from
dersam,
juniper-shopify,
mathiusj and
nfgrep
as code owners
July 3, 2026 16:30
mathiusj
approved these changes
Jul 3, 2026
mathiusj
reviewed
Jul 3, 2026
mathiusj
left a comment
mathiusj
left a comment
Contributor
There was a problem hiding this comment.
read formatters look good. Two edge/consistency notes.
mathiusj
approved these changes
Jul 3, 2026
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-read
branch
from
July 10, 2026 15:23
2162423 to
9774c62
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-bash
branch
from
July 10, 2026 15:23
3ee55e7 to
542e96a
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-read
branch
2 times, most recently
from
July 10, 2026 16:38
eecfae1 to
daeaf21
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-read
branch
from
July 14, 2026 20:37
daeaf21 to
e3989e8
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-bash
branch
from
July 14, 2026 20:37
542e96a to
2937e7c
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-bash
branch
from
July 30, 2026 14:41
2937e7c to
75d9854
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-read
branch
from
July 30, 2026 14:41
e3989e8 to
27e0d9d
Compare
Contributor
Author
Merge activity
|
LasmarKhalifa
changed the base branch from
06-30/pi-tool-formatter-bash
to
graphite-base/1016
August 5, 2026 15:42
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-read
branch
from
August 5, 2026 15:44
27e0d9d to
5bc3314
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1024