Skip to content

Silence a GCC dangling-reference warning in controller parsing #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kahrendt merged 1 commit into from
Aug 12, 2026
Merged

Silence a GCC dangling-reference warning in controller parsing #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/protocol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,8 +550,9 @@ bool process_server_state_controller(JsonObject root,
// command is a non-compliant value rather than a forward-compatible one: drop and log it.
if (controller_object["supported_commands"].is<JsonArray>()) {
std::vector<SendspinControllerCommand> commands;
for (JsonVariantConst command_var :
controller_object["supported_commands"].as<JsonArrayConst>()) {
JsonArrayConst commands_array =
controller_object["supported_commands"].as<JsonArrayConst>();
for (JsonVariantConst command_var : commands_array) {
if (auto command = read_enum_field(command_var, "supported_commands",
controller_command_from_string)) {
commands.push_back(*command);
Expand Down
Loading