docs: adopt towncrier changelog#7166
Merged
Merged
Conversation
github-actions
Bot
added
the
benchmark_this
![scitools-ci[bot]](https://avatars.githubusercontent.com/in/212324?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Templating
This PR includes changes that may be worth sharing via templating. For each file listed below, please either:
- Action the suggestion via a pull request editing/adding the relevant file in the SciTools/.github
templates/directory. 1 - Raise an issue against the SciTools/.github repo for the above action if you really don't have 10mins spare right now. Include an assignee, to avoid it being forgotten.
- Dismiss the suggestion if the changes are not suitable for templating.
You will need to dismiss this review before this PR can be merged. Recommend the reviewer does this as their final action before merging, as this text will continually update as commits come in.
Templated files
The following changed files are templated:
-
MANIFEST.in, templated bySciTools/.github/templates/MANIFEST.in -
pyproject.toml, templated bySciTools/.github/templates/pyproject.toml
Template candidates
The following changed files are not currently templated, but their parent directories suggest they may be good candidates for a new template to be created:
Footnotes
-
Include this text in the PR body to avoid any notifications about applying the template changes back to the source repo!
@scitools-templating: please no update notification on: iris↩
Contributor
⏱️ Performance Benchmark Report: 0bf4d74Performance shiftsFull benchmark resultsGenerated by GHA run |
Contributor
⏱️ Performance Benchmark Report: 1db1011Performance shiftsFull benchmark resultsGenerated by GHA run |
Member
I guess you can't avoid updating the lockfiles, so the new matplotlib thing is inevitably in the way here. Is it possible to create a workflow check for a new fragment with every PR ? |
Member
Author
I'm going to leave that as a follow-on PR 👍 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7166 +/- ##
=======================================
Coverage 90.15% 90.15%
=======================================
Files 91 91
Lines 24983 24983
Branches 4685 4685
=======================================
Hits 22524 22524
Misses 1682 1682
Partials 777 777 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
⏱️ Performance Benchmark Report: 3403066Performance shiftsFull benchmark resultsGenerated by GHA run |
Contributor
⏱️ Performance Benchmark Report: abda11bPerformance shiftsFull benchmark resultsGenerated by GHA run |
This was referenced Jun 24, 2026
tkknight
reviewed
Jun 24, 2026
Co-authored-by: tkknight <2108488+tkknight@users.noreply.github.com>
bjlittle
removed
the
benchmark_this
github-actions
Bot
added
the
benchmark_this
bjlittle
removed
the
benchmark_this
tkknight
approved these changes
Jun 24, 2026
Member
Author
|
@tkknight Awesome! Thanks 🎉 |
Contributor
⏱️ Performance Benchmark Report: d21659aPerformance shiftsFull benchmark resultsGenerated by GHA run |
Contributor
⏱️ Performance Benchmark Report: 2e7ef83Performance shiftsFull benchmark resultsGenerated by GHA run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull-request migrates to using
towncrierfor managing development and release changelogs.By its nature, this pull-request will go stale quickly. Additionally, this pull-request is noisy and will cause disruption to other open pull-requests.
I've intentionally not updated the
donothingscript. However, I have banked the general process within the docs, which will serve as a template for the future changes to thedonothingscript. This should be done as a follow-on task.I recommend that we first need to understand and agree on the new changelog process - so I'm separating concerns here to expedite this PR getting banked.
TODO:
matplotlib <3.11andpytest <9.1to avoid known failuresdonothingscript to encode new changelog process once its agreed and establishedrelease_do_nothing.pyfortowncrierchangelog #7169towncrierchangelog news fragment quality assurance #7170towncrierchangelog process for point (patch) releases #7171