inject host time into datastream wasm rules engine (SCHY-471)#87
Merged
cbrady merged 2 commits intoJul 13, 2026
Conversation
The raw wasm has no clock under wasmtime, so metric-period reset computation trapped (wasm unreachable) and entitled companies wrongly fell back to the flag default. Call setCurrentTimeMillis with the host wall-clock before checkFlagCombined; add a regression test that reproduces the trap and asserts correct evaluation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Annotate the _entitled_company fixture as RulesengineCompany instead of object so it type-checks as check_flag's company argument. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
cbrady
force-pushed
the
chris/schy-471-datastream-wasm-rules-engine-panics-unreachable-on-wasmtime
branch
from
55919ba to
b605771
Compare
bpapillon
approved these changes
Jul 13, 2026
cbrady
deleted the
chris/schy-471-datastream-wasm-rules-engine-panics-unreachable-on-wasmtime
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The raw wasm has no clock under wasmtime, so metric-period reset computation trapped (wasm unreachable) and entitled companies wrongly fell back to the flag default. Call setCurrentTimeMillis with the host wall-clock before checkFlagCombined; add a regression test that reproduces the trap and asserts correct evaluation.