selector: avoid nil deref when no outbound is selected - #4102
Open
SAY-5 wants to merge 240 commits into
Open
Conversation
nekohasekai
force-pushed
the
testing
branch
2 times, most recently
from
May 3, 2026 01:08
8f15b13 to
9ee56ae
Compare
nekohasekai
force-pushed
the
testing
branch
6 times, most recently
from
May 15, 2026 05:29
057f540 to
6b07a22
Compare
nekohasekai
force-pushed
the
testing
branch
4 times, most recently
from
May 21, 2026 04:55
82e84f9 to
abac453
Compare
SAY-5
force-pushed
the
say5/selector-nil-selected-3917
branch
from
May 21, 2026 05:45
b51af84 to
d379866
Compare
SAY-5
force-pushed
the
say5/selector-nil-selected-3917
branch
from
May 21, 2026 19:17
d379866 to
174db70
Compare
nekohasekai
force-pushed
the
testing
branch
4 times, most recently
from
May 26, 2026 09:45
2141845 to
b6c416b
Compare
nekohasekai
force-pushed
the
testing
branch
3 times, most recently
from
June 3, 2026 05:05
de161cf to
83b7304
Compare
nekohasekai
force-pushed
the
testing
branch
7 times, most recently
from
June 13, 2026 15:01
1ed57eb to
8247670
Compare
Batched darwin packet I/O now also covers connected sockets on iOS.
- Limit SubscribeGroups and SubscribeOutbounds to one push per 250ms, coalescing bursts of URLTest updates
…ient_subnet DNS route action option
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Author
|
Rebased on testing. NewDirectRouteConnection is gone from Selector upstream so that guard dropped out, the other four still load selected without a nil check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3917.
Selector.DialContext/ListenPacket/NewConnection/NewPacketConnection/NewDirectRouteConnectionall calleds.selected.Load()and immediately dereferenced the result.Network()andNow()already nil-check; the connection-side methods didn't. After SFA disconnect+reconnect,selectedcan be nil and the next dial panics, guard each callsite.