fix(timeline): refresh rows whose event decrypted after they were cached - #1583
Open
eleboucher wants to merge 1 commit into
Open
fix(timeline): refresh rows whose event decrypted after they were cached#1583eleboucher wants to merge 1 commit into
eleboucher wants to merge 1 commit into
Conversation
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-1583-sable.raspy-dream-bb1d.workers.dev | 9505467 | pr-1583 |
Sun, 02 Aug 2026 09:45:28 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
messages in encrypted rooms only showed up if they arrived while the app was foregrounded. anything from cache stayed blank until you cleared it.
the append-only fast path in useProcessedTimeline validated its cache on mEvent identity, but decryption mutates the event in place. rows built while the event was still encrypted kept the ciphertext content, and later live messages reused the stale prefix. #1555 exposed this. before it, still-encrypted events were filtered out so nothing stale got cached.
entries now carry clearType/clearContent when the event is encrypted, and the prefix guard compares those too.
also coalesced handleDecrypted onto one frame. decryptions land in separate tasks, so a 25 event backlog meant 25 full reprocesses.
Fixes #
Type of change
Checklist:
AI disclosure: