fixup for 6/25 changes#139
Open
jenbreese wants to merge 1 commit into
Open
Conversation
majimmy88
reviewed
Jun 26, 2026
| onBlur={(e) => handleInputBlur(e.target.value, setPayment)} | ||
| className={`border-border pl-7 bg-card ${getFieldError("payment") ? "border-2 border-[var(--color-inline-error)]" : ""}`} | ||
| /> | ||
| {solveFor !== "PMT" && |
There was a problem hiding this comment.
Not something we need fixed here, but I'm noticing a lot of code formatting with no actual changes. We should implement a unified code formatter so the code reviews are smaller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Time Value of Money Calculator: Bug fixes and code quality improvements
Bug fixes
-$-1,000,000,000. Present value, future value, and payment error messages now correctly format as-$1,000,000,000.Code quality
HowToUseInfoBox: Inlined the component JSX directly into the render output. Previously defined as a function insidePage(), it was recreated on every render, causing React to see a new component type each render and fully remount it, resetting any internal state.