Fix Mac CI linking after SDK bump: rewrite ITK's hardcoded SDK .tbd paths#2571
Merged
Conversation
…aths ITK's exported CMake targets hardcode absolute paths to macOS SDK stub libraries (libiconv.tbd, libm.tbd) in INTERFACE_LINK_LIBRARIES. The dependency install is cached keyed on the dependency-script hashes, so a runner Xcode/SDK bump leaves those absolute paths dangling and every Mac target that links ITK fails with "No rule to make target .../libiconv.tbd". Add fix_mac_dependency_paths.sh to rewrite SDK-versioned system-library .tbd paths to -l flags, and run it in both Mac workflows after the dependency cache step (per-run, so it does not invalidate the cache). Fixes #2570
akenmorris
force-pushed
the
amorris/mac-ci-libiconv-fix
branch
from
faa1564 to
0106a72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ITK's exported CMake targets hardcode absolute paths to macOS SDK stub libraries (libiconv.tbd, libm.tbd) in INTERFACE_LINK_LIBRARIES. The dependency install is cached keyed on the dependency-script hashes, so a runner Xcode/SDK bump leaves those absolute paths dangling and every Mac target that links ITK fails with "No rule to make target .../libiconv.tbd".
Add fix_mac_dependency_paths.sh to rewrite SDK-versioned system-library .tbd paths to -l flags, and run it in both Mac workflows after the dependency cache step (per-run, so it does not invalidate the cache).