digest-io-async: initial commit - #1518
Open
baloo wants to merge 1 commit into
Open
Conversation
Member
Author
|
This is a follow up on #1517 |
This introduces a new crate providing `HashReader`/`HashWriter` wrappers implementing `AsyncRead`/`AsyncWrite`, mirroring `digest-io`'s sync API. This only implement the tokio's async API for now, and it is gated behind a `tokio` feature. The intent is to fold it in `digest-io` when the `AsyncReader`/`AsyncWriter` eventually make their way into `std`.
baloo
force-pushed
the
push-kxltlypsyruw
branch
from
August 15, 2026 01:07
41d3d1f to
33ba71a
Compare
newpavlov
reviewed
Aug 15, 2026
| @@ -0,0 +1,25 @@ | |||
| Copyright (c) 2025 The RustCrypto Project Developers | |||
| tokio-util = { version = "0.7", features = ["io"] } | ||
|
|
||
| [features] | ||
| tokio = ["dep:tokio", "dep:pin-project-lite"] |
Member
There was a problem hiding this comment.
I think we can remove the tokio crate feature for now. If we are to add support for other executors we could bring it back in a future breaking release.
newpavlov
reviewed
Aug 16, 2026
| "ctutils", | ||
| "cpufeatures", | ||
| "dbl", | ||
| "digest-io", |
Member
There was a problem hiding this comment.
digest-io was intentionally excluded from the workspace (see below). Do the same for digest-io-async.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new crate providing
HashReader/HashWriterwrappers implementingAsyncRead/AsyncWrite, mirroringdigest-io's sync API.This only implement the tokio's async API for now, and it is gated behind a
tokiofeature.The intent is to fold it in
digest-iowhen theAsyncReader/AsyncWritereventually make their way intostd.