Alert before crashing on infra failures instead of failing silently i… - #17
Open
ashleigh-byte wants to merge 2 commits into
Open
Alert before crashing on infra failures instead of failing silently i…#17ashleigh-byte wants to merge 2 commits into
ashleigh-byte wants to merge 2 commits into
Conversation
…n logs Speed test, device scan, database, and notifier-delivery failures still crash the process (existing project philosophy: don't silently retry forever), but now make a best-effort attempt to post an alert to the configured notifier first, so the failure is visible without checking server logs. A failure to send that alert itself is logged separately and never masks the original exception. Validated against real production incidents: a missing sudoers grant, a disk-full DB write, and a DNS outage that took down both the speed test and the notifier webhook at once -- in all three cases the alert attempt fails alongside the primary error, and the original exception still propagates and crashes the process rather than being swallowed. The existing AI-backend-failure handling (falls back to plain text, does not crash) is untouched -- that's a deliberately different philosophy: an AI hiccup degrades gracefully, an infra failure is a real bug in netmon and should be loud.
Adds a Reliability section explaining that infra failures (speed test, device scan, database, notifier) post a best-effort alert then crash rather than silently retrying, and contrasts this with the existing graceful-degradation behavior for AI backend failures specifically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed test, device scan, database, and notifier-delivery failures still crash the process (existing project philosophy: don't silently retry forever), but now make a best-effort attempt to post an alert to the configured notifier first, so the failure is visible without checking server logs. A failure to send that alert itself is logged separately and never masks the original exception.
Validated against real production incidents: a missing sudoers grant, a disk-full DB write, and a DNS outage that took down both the speed test and the notifier webhook at once -- in all three cases the alert attempt fails alongside the primary error, and the original exception still propagates and crashes the process rather than being swallowed.
The existing AI-backend-failure handling (falls back to plain text, does not crash) is untouched -- that's a deliberately different philosophy: an AI hiccup degrades gracefully, an infra failure is a real bug in netmon and should be loud.