chore: regenerate for the forecast verification halt [HOLD — needs robosystems#1109] - #179
Merged
Merged
Conversation
Additive, from robosystems#1109. ComputeForecastResponse gains `halted_at`: the month where the forecast walk stopped because verification failed, or null if it ran the full horizon. Each month's opening balances are the previous month's closing balances, so computing past a failure yields months derived from a known-wrong one rather than merely unverified ones — the walk now stops and names where. ForecastMonthLite.verification_passed keeps its type and gains an honest description. It is tri-state and the third state is not the first: true = rules ran and passed, false = something failed (which halts the walk), null = no rules ran, so the month is unverified rather than verified. Consumers had been treating null and true alike. DO NOT MERGE BEFORE robosystems#1109. This was regenerated against a local stack carrying that branch, not against origin/main — the server does not return `halted_at` yet and does not halt. Merging first would publish a client documenting behaviour the deployed API doesn't have. Gate: 519 passed, ruff + format + basedpyright clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was regenerated against a local stack carrying that branch, not against
origin/main. The server does not returnhalted_atyet and does not halt. Merging and publishing first would ship a client documenting behaviour the deployed API doesn't have — including a description telling integrators thatfalsehalts the walk, when the deployed server never halts.Additive, so no version concern — purely an ordering one.
What
ComputeForecastResponse.halted_at— the month where the forecast walk stopped because verification failed, or null if it ran the full horizon.Each month's opening balances are the previous month's closing balances, so computing past a failure doesn't yield merely unverified months — it yields months derived from a known-wrong one. The walk now stops and names where, and
months_computedends there.ForecastMonthLite.verification_passed— same type, honest description. It is tri-state and the third state is not the first:truefalsenullConsumers had been treating
nullandtruealike, which meant a rule corpus that silently stopped binding would have looked like a passing forecast.Gate
519 passed, 17 skipped.
ruff check+ruff format --check+basedpyrightclean.