Make handler parameter nullable in WpClient constructor (#1)#2
Open
jgalea wants to merge 3 commits into
Open
Conversation
Allows php-http/discovery's ClassDiscovery to instantiate WpClient without arguments. When null is passed, the constructor falls back to HandlerStack::createDefault(). Closes #1
composer.json didn't declare allow-plugins, so the non-interactive composer update in CI aborted on the phpcodesniffer-installer and package-versions-deprecated plugins. Allow-list both.
WordPress 6.2 moved the bundled Requests library to wp-includes/Requests/src and renamed the classes to the WpOrg\Requests namespace. The bootstrap hardcoded the old wp-includes/Requests/Utility paths, so PhpUnit fatally errored on any WP core that Composer resolved at 6.2+. Load the new autoloader when present, fall back to the legacy files otherwise, and reference the modern class name in the WpHandler test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
$handlerparameter ofWpClient::__constructnullable with anulldefault, allowingphp-http/discovery'sClassDiscoveryto instantiateWpClientwithout arguments.When
nullis passed (or no argument is given), the constructor falls back toHandlerStack::createDefault(), which is the same default used by the existingWpClient::createDefault()factory method.Closes #1