revert: remove Global ETF research contract - #305
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9c0a95c8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| exact_mandate_errors = _exact_tqqq_mandate_errors( | ||
| mandate_provenance, | ||
| effective_at=effective_at, | ||
| expires_at=expires_at, | ||
| ) |
There was a problem hiding this comment.
When a caller continues submitting global_etf_rotation_etf_only_research_v1 provenance, this now passes the generic mandate checks rather than being revoked: an otherwise valid former Global ETF payload with risk_control_state=None receives APPROVE, retains its positions, and has no stop-loss or risk-control-state digest. Because _risk_control_fields also ignores every mandate except TQQQ, removing the dedicated validator silently bypasses the former position-count, aggregate loss-budget, stop-intent, drawdown, and breaker checks. Explicitly reject this retired mandate ID instead of allowing it to fall through as an arbitrary generic mandate.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
No remediation is authorized on this revert PR. Any material exact-head blocker will close this PR unmerged and terminally park the Global ETF research contract.