fix(analysis): allow safe contained instruction aliases - #51
Open
oldwinter wants to merge 5 commits into
Open
Conversation
Resolve structural entries canonically so tracked provider adapters inside the topology root remain inspectable while escaping links stay rejected. Tests: node --test test/workspace-topology.test.mjs; frozen general-tasks evidence-bundle Co-authored-by: Codex (GPT 5.6 Sol) <codex@openai.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the workspace-topology discovery logic to allow a narrowly-scoped class of safe, contained, tracked instruction-route symlinks (e.g., CLAUDE.md -> AGENTS.md) while continuing to reject unsafe symlink patterns. It also documents the topology contract and adds regression tests to lock in the intended behavior.
Changes:
- Allow direct, same-directory, tracked instruction-route symlink redirects inside the Git root and read content via the canonical target path.
- Add workspace topology tests covering accepted contained instruction links and multiple rejected symlink topologies (cross-scope, chained hop, ignored/untracked/non-structural targets, manifest aliasing).
- Add a spec describing intent, acceptance scenarios, non-goals, and verification evidence.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/workspace-topology.test.mjs | Adds regression coverage for accepting a contained tracked instruction symlink and rejecting unsafe symlink variants. |
| scripts/workspace-topology/manifests.mjs | Implements canonical-path-based structural safety checks and narrowly permits safe instruction-route symlink redirects. |
| docs/specs/2026-08-02-contained-structural-symlinks.md | Documents the accepted symlink topology contract, risks, and verification steps. |
Suppressed comments (1)
scripts/workspace-topology/manifests.mjs:192
safeRedirectrelies on case-sensitive route comparisons (canonicalRoute === item.route,trackedRoutes.has(canonicalRoute), anddirnameRoute(...) === ...). On Windows’ default case-insensitive filesystems this can incorrectly mark safe structural files/links as unsafe whenrealpath()returns different casing. Suggest using a win32-normalized key (e.g. lowercased) for these route comparisons while keeping the originalroutevalues for reporting.
const canonicalRoute = path.relative(canonicalRoot, canonical).split(path.sep).join("/");
const safeRedirect = canonicalRoute === item.route
|| (
item.provenance === "tracked"
&& trackedRoutes.has(canonicalRoute)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+171
to
+174
| const target = path.normalize(await readlink(absolute)); | ||
| return !path.isAbsolute(target) | ||
| && path.dirname(target) === "." | ||
| && path.resolve(path.dirname(absolute), target) === canonical; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
node --test test/workspace-topology.test.mjs(16 tests passed)npm run checkafternpm ci(1101 tests passed; npm package and runtime bundle verification passed)No matching open upstream issue was found.