fix: use error estimation config in levels contexts#211
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors infer_glycopeptides to consistently read error-estimation parameters from the nested config.error_estimation_config, aligning glycopeptide-level inference with the rest of the level-context workflows and centralizing error-estimation settings.
Changes:
- Updated the glycopeptide (global / experiment-wide) inference path to pass error-estimation parameters via
config.error_estimation_config.*instead ofconfig.*. - Keeps the glycopeptide inference API the same while making configuration usage consistent and easier to maintain.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how error estimation parameters are accessed in the
infer_glycopeptidesfunction, improving code organization and maintainability by grouping related configuration values undererror_estimation_config.Configuration refactoring:
levels_contexts.pyso that error estimation parameters (such asparametric,pfdr,pi0_lambda, etc.) are now accessed viaconfig.error_estimation_configinstead of directly fromconfig. This centralizes error estimation settings and makes the codebase easier to manage.