Skip to content

fix: use error estimation config in levels contexts#211

Merged
singjc merged 2 commits into
PyProphet:masterfrom
singjc:split/levels-contexts-fix
Jun 17, 2026
Merged

fix: use error estimation config in levels contexts#211
singjc merged 2 commits into
PyProphet:masterfrom
singjc:split/levels-contexts-fix

Conversation

@singjc

@singjc singjc commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

This pull request updates how error estimation parameters are accessed in the infer_glycopeptides function, improving code organization and maintainability by grouping related configuration values under error_estimation_config.

Configuration refactoring:

  • Updated the function call in levels_contexts.py so that error estimation parameters (such as parametric, pfdr, pi0_lambda, etc.) are now accessed via config.error_estimation_config instead of directly from config. This centralizes error estimation settings and makes the codebase easier to manage.

Copilot AI review requested due to automatic review settings June 17, 2026 23:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors infer_glycopeptides to consistently read error-estimation parameters from the nested config.error_estimation_config, aligning glycopeptide-level inference with the rest of the level-context workflows and centralizing error-estimation settings.

Changes:

  • Updated the glycopeptide (global / experiment-wide) inference path to pass error-estimation parameters via config.error_estimation_config.* instead of config.*.
  • Keeps the glycopeptide inference API the same while making configuration usage consistent and easier to maintain.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@singjc singjc merged commit f5dfc11 into PyProphet:master Jun 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants