Verify King's Quest IV: The Perils of Rosella - #681
Open
tomojira wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying King's Quest IV - The Perils of Rosella (1988) (Sierra On-Line)
This game is already in the verified section, but giving it another look with the checklist since it was added early on.
Checklist
Have adequate installation instructions been provided to match any config files in the DOSZ?
Config files are not required in the DOSZ.
RESOURCE.CFGcan be created byINSTALL.EXEat any time.GOG is different however - they didn't provide
INSTALL.EXE, soRESOURCE.CFGneeds to be in the DOSZ there.I added a copy of it to the DOSC since it was missing there.
Have any official patches been applied, if necessary?
No official patches according to PCGamingWiki.
Is the game data in the root of the ZIP (unless game does not work that way)?
Yes.
For games which include CD images, is there a smaller installation variant that offers the same features but needs less files?
Not applicable.
Is the entry in the right variant file (i.e. Freeware)?
Yes.
Have digital versions (Steam, GOG) been checked for matching?
Yes, there is already a GOG variant.
Can the game benefit from using embedded data or embedded patches in the datfile?
Main variant: No.
GOG variant: I added embedded data to
RESOURCE.CFG.Can DoDAT build the game from the install media?
Yes.
If the game requires a yml in the DOSZ, has it been added to the yml folder in the repo?
Not applicable.
Are there .PIF or .ICO or Win32 .EXE files that could be excluded?
No.
Do the file timestamps match the installation media?
Yes.
Does the DOSZ run standalone?
Yes, after running the setup program to create the config file.
For CD games, can the game be set up to run without a CD mounted?
Not applicable.
Can the game benefit from using CHDtoOGG?
Not applicable.
Is the game creating a swap file in the .pure.zip that could be avoided by increasing memory size? Or is it creating other bloated files that could be prevented by adding them in the DOSZ?
No.
Does the DOSC contain problematic data (i.e. copyright issue)?
No.
Does the DOSC have copy protection removed, if possible?
Main variant: Yes, it's already removed.
GOG variant: Copy protection is still there, so I copied the patch over.
Is the game running at the correct speed? Is CPU year specified?
No CPU year was specified. I added
cpu_year: 1988to both variants since there didn't seem to be speed problems at the beginning of the game.Is the DOSC auto-running and skipping past any obstructions? Is it updated to use WAITMODECHANGE if possible?
Yes.
Does the game have MT-32 support? If so, is it correctly using MT-32 (old) or CM-32L (new), going by the Vogons Wiki?
Main variant: Yes, it's using "old".
GOG variant: It was missing, so I copied it over.
Does the game have General MIDI support?
No.
Is the game set up to run with the best quality graphics options by default?
Not applicable.
For certain old games only - are the graphics/audio improved by specifying video_card: pcjr, tandy, or generic_cga?
No. There is a different version that benefits from Tandy over PC speaker, but this more advanced version supports Adlib and MT-32.
Does the game have a mouse cursor that benefits from enabling input_directmouse?
Yes, I added it to both variants.
Does a game with separate episodes/executables have the options named and ordered properly in the DOSZ? Do they use the run_utility feature?
Not applicable.
Does the game share saves with a sequel, expansion, etc? If so, is it updated to use the .savename feature?
Not applicable.
Summary of changes
RESOURCE.CFGto DOSCRESOURCE.CFGfor DOSZcpu_year: 1988Other changes not mentioned in the checklist:
Readme_new.txtwas unnecessarily included in the DOSZ (not an original file from the game), so I removed itminHunk, which has caused problems in other Sierra games when it's missing. That didn't seem to be the case when starting this game, but just in case, I replaced the config files in the DOSC with these complete versions (only the directory path was edited)