Stdlib: DateTime @unix timestamp parse (#10858)#18566
Merged
Merged
Conversation
Teach DateTimeSupport to detect leading @<digits> time strings per php-src ext/date/php_date.c — set epoch from numeric suffix and force +00:00 timezone regardless of default tz or ctor timezone arg. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Zend accepts unix-timestamp strings with an
@prefix fordate_create('@0'),new DateTime('@0'), andDateTimeImmutable('@0'). VM failed to parse:date_create()warned and returnedfalse; constructors threw misleading timezone errors.php-src reference:
ext/date/php_date.c—php_parse_date()@unix timestamp branchFix
PHP-in-PHP in
lib/VM/DateTimeSupport.php:tryParseAtUnixTimestampString()for@<int|float>suffixinitDateTime()andtryNewDateTimeLikeVariable()(date_create()path)@form sets timestamp directly with+00:00timezone (Zend TIMELIB_ZONETYPE_OFFSET), ignoring default/ctor timezoneNo new C runtime logic.
Verification
Closes #10858
Made with Cursor