Stdlib: openssl_pkcs12_read/export/export_to_file() — PKCS#12 keystore API (#6420)#18530
Merged
Conversation
Add PKCS#12 keystore read/write via ext/openssl FFI (php-src pkcs12.c), with by-ref output wiring and compliance round-trip coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve conflicts with openssl_x509_verify landing; dedupe spine XmlrpcExtensionPolicy include and refresh docs to 4751/4751. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
Owner
Author
|
Maintainer triage (2026-07-13): test plan and php-src refs look good, but GitHub reports mergeable: CONFLICTING. Please rebase onto current Local spot-check: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openssl_pkcs12_read(),openssl_pkcs12_export(), andopenssl_pkcs12_export_to_file()on the VM viaext/openssl/VmOpensslPkcs12Native.php(libcrypto FFI; php-srcext/openssl/pkcs12.c).$certificates/$outputindices inBuiltinByRefParamsand add compliance + maintainer round-trip guards.ext/openssl/*inventory files.php-src reference
ext/openssl/pkcs12.c—PHP_FUNCTION(openssl_pkcs12_read|export|export_to_file)PKCS12_create(..., 0, 0, 0, 0, 0)default cipher/MAC params (OpenSSL 3 PBES2 defaults)Test plan
Verification output (Jul 2026):
maintainer_openssl_pkcs12.php→okopenssl_pkcs12_roundtripVMTest → OK (2 tests)BuiltinByRefParamsTest→ OK (18 tests)check-generated-docs.sh→ all in syncCloses #6420
Made with Cursor