Stdlib/AOT: DOMXPath::evaluate() dedicated LLVM leaf (#18526)#18527
Merged
Conversation
#18493 fixed query() only; evaluate() still routed through generic VmDomInstanceInvoke and aborted in user-script standalone. Add JitDomXPathEvaluate + compile-time boolean/count fast path and scalar runtime bridges matching php-src ext/dom/xpath.c. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DOMXPath::evaluate()(re-Stdlib/AOT: DOMXPath::query()/evaluate() compile fatal in user-script standalone (ext/dom/xpath.c, #6066 follow-up) #18493 gap):JitDomXPathEvaluate, compile-timeboolean()/count()fast path, and scalar runtime bridges viaDomXPathEvaluateJitHelperdomxpath::evaluatefrom genericVmDomInstanceInvoketoUSER_SCRIPT_DIRECT_METHODS(same pattern asquery())php-src reference
ext/dom/xpath.c—dom_xpath_object_evaluate_readPHP implementation
ext/dom/JitDomXPathEvaluate.php,JitDomXPathEvaluateUserScript.php,DomXPathEvaluateJitHelper.phplib/JIT/Call/DomXPathEvaluate.php,lib/JIT/Builtin/DomXPathEvaluateRuntime.phplib/JIT/DomInstanceMethodJit.php— register dedicated proxyVerification
Closes #18526
Made with Cursor