feat: extract block shape offsets - #54
Open
MegalithOfficial wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pumpkin needs vanilla’s position-based block shape offsets for Pumpkin-MC/Pumpkin#2869. These values were previously written by hand in Pumpkin.
This adds
shape_offsetmetadata directly to affected entries inblocks.json. The Extractor determines which blocks have an offset function and extracts the offset type, maximum horizontal offset and maximum vertical offset from the vanilla block implementation.This currently extracts 39 blocks: 34 with XZ offsets and 5 with XYZ offsets. It also correctly extracts special limits such as
0.125for pointed dripstone and sulfur spikes, and0.1vertical offset for small dripleaf.I also removed an obsolete access-widener entry for
markPosForPostprocessing. The method is already public in 26.2 undermarkPosForPostProcessing.