Skip to content

Calendar: update related feed news on patch#77

Open
armanddidierjean wants to merge 1 commit into
devfrom
calendar-update-feed
Open

Calendar: update related feed news on patch#77
armanddidierjean wants to merge 1 commit into
devfrom
calendar-update-feed

Conversation

@armanddidierjean

Copy link
Copy Markdown

Description

Summary

Update related news when patching calendar events. Allows to change the linked tickets' event or event_url

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@codecov

codecov Bot commented Jun 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
app/core/feed/cruds_feed.py 80.00% 1 Missing ⚠️
app/core/feed/utils_feed.py 75.00% 1 Missing ⚠️
app/modules/calendar/endpoints_calendar.py 96.55% 1 Missing ⚠️
app/modules/calendar/utils_calendar.py 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@armanddidierjean armanddidierjean force-pushed the ticket-changeover-prop branch 2 times, most recently from 2f9b4f6 to 5b0e03c Compare June 30, 2026 19:24
Base automatically changed from ticket-changeover-prop to dev July 1, 2026 07:37
@armanddidierjean armanddidierjean marked this pull request as ready for review July 1, 2026 07:41
db: AsyncSession,
):
"""
module: could be "event" or "ticket"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we add check to ensure this then ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, but I'm not sure if we want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

calendar enhancement New feature or request feed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants