Skip to content

[codex] infer createClientEffect output channels#21

Merged
skulidropek merged 1 commit into
ProverCoderAI:mainfrom
skulidropek:codex/effect-client-infer-output
Jun 18, 2026
Merged

[codex] infer createClientEffect output channels#21
skulidropek merged 1 commit into
ProverCoderAI:mainfrom
skulidropek:codex/effect-client-infer-output

Conversation

@skulidropek

Copy link
Copy Markdown
Member

Summary

  • Adds a strict Effect-channel createClientEffect API with openapi-fetch-style method inputs.
  • Infers success and failure output channels from createClientEffect<paths>(), without per-call output schemas, dispatchers, or hardcoded operation response types.
  • Keeps non-2xx responses in the Effect error channel and transport/parse/content-type failures as typed boundary errors.

Mathematical guarantees

  • Input invariant: Path ∧ Method selects exactly one OpenAPI operation from Paths.
  • Output invariant: responses from the selected operation determine ApiSuccess<Responses> and ApiFailure<Responses>.
  • Runtime invariant: 2xx -> success channel; non-2xx -> HttpError; boundary failures remain typed boundary errors.

Validation

  • corepack pnpm -C packages/app typecheck
  • corepack pnpm -C packages/app lint
  • corepack pnpm -C packages/app lint:tests
  • corepack pnpm -C packages/app exec vitest run (114 passed)
  • corepack pnpm -C packages/app build
  • corepack pnpm -C packages/app lint:effect
  • git diff --check

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@skulidropek, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 4 minutes and 49 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: df64b511-4b63-41c5-aabe-815efb7c7f77

📥 Commits

Reviewing files that changed from the base of the PR and between 6b3e168 and 2950b6f.

📒 Files selected for processing (16)
  • README.md
  • packages/app/src/core/axioms.ts
  • packages/app/src/index.ts
  • packages/app/src/shell/api-client/create-client-effect-types.ts
  • packages/app/src/shell/api-client/create-client-middleware.ts
  • packages/app/src/shell/api-client/create-client-response.ts
  • packages/app/src/shell/api-client/create-client-runtime-methods.ts
  • packages/app/src/shell/api-client/create-client-runtime-types.ts
  • packages/app/src/shell/api-client/create-client-runtime.ts
  • packages/app/src/shell/api-client/create-client-types.ts
  • packages/app/src/shell/api-client/create-client.ts
  • packages/app/src/shell/api-client/index.ts
  • packages/app/tests/api-client/auth-type-tests.test.ts
  • packages/app/tests/api-client/create-client-effect-integration.test.ts
  • packages/app/tests/api-client/create-client-effect-type-tests.test.ts
  • packages/app/tests/api-client/create-client-effect.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skulidropek

skulidropek commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

AI Session Backup

Commit: 2950b6f
Status: success
Files: 3 (2.36 MB)
Links: README | Manifest

git status

On branch codex/effect-client-infer-output
Your branch is up to date with 'origin/codex/effect-client-infer-output'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	scripts

nothing added to commit but untracked files present (use "git add" to track)

@skulidropek skulidropek marked this pull request as ready for review June 18, 2026 09:59
@skulidropek skulidropek merged commit df5a3e0 into ProverCoderAI:main Jun 18, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant