Clip upsell card ripple to card shape - #190
Open
MAHAN-VS-MAHAN wants to merge 3 commits into
Open
Conversation
MAHAN-VS-MAHAN
force-pushed
the
fix-home-card-ripple-clipping
branch
from
August 3, 2026 18:38
fbc5047 to
268efa2
Compare
Author
|
Rebased onto current master (5.19.61.0).... The earlier conflicts came from a stale base not from this change... the diff is now a single commit touching only UpsellCarousel.kt. Clips the clickable area to ProtonTheme.shapes.medium, matching the card's own shape.... so the pressed-state ripple no longer renders with sharp corners.... Verified on device (screenshots above).... I've since changed machines and can't run detekt locally at the moment, but I'm happy to address anything CI or review flags.... |
AlgirdasPundzius
force-pushed
the
master
branch
from
August 4, 2026 06:58
769cbdd to
9201338
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the pressed/ripple indication on the Home screen upsell carousel cards so it respects the same rounded shape as the card.
The clickable modifier was applied without clipping, which caused the pressed indication to render with sharp corners. This change clips the clickable area using the same medium shape as the card.
before:
after:
Tested: