fix(flags): align local cohort evaluation with backend - #836
Open
marandaneto wants to merge 3 commits into
Open
Conversation
Contributor
posthog-python Compliance ReportDate: 2026-08-07 07:46:31 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
Contributor
|
Reviews (1): Last reviewed commit: "fix(flags): accept nested empty cohort g..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The backend returns cohort definitions as nested property groups and omits static cohorts that require server evaluation. Python local evaluation could ignore
not_in, treat malformed non-empty groups as matching everyone, or skip a missing nested cohort after another branch resolved the group.This change aligns Python cohort evaluation with the backend response contract and the corresponding Rust SDK work in PostHog/posthog-rs#187.
It now applies cohort membership operators, accepts the backend's canonical empty group representation, rejects malformed groups, and falls back to the server whenever a nested static or missing cohort appears.
💚 How did you test it?
uv run --extra test pytest -q- 2052 passed, 15 skippeduv run ruff format --check .uv run ruff check .origin/mainreported no actionable findings.📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi and the autoreview skill were used to compare the Python and Rust SDK behavior with the backend serializer. The implementation preserves valid empty groups while making missing cohorts and malformed definitions fall back to server evaluation regardless of branch order.