Fix simulation request correlation and service metadata - #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #658
Summary
X-PolicyEngine-Request-IdAPP_ENVIRONMENTwithout changing the existing environment precedenceRoot cause
The Entrypoint forwarded
X-Request-ID, butpolicyengine-observabilityreadsX-PolicyEngine-Request-Id, so the Modal gateway generated a different UUID. The shared FastAPI initializer also hard-coded the executor service name and did not consider the Cloud RunAPP_ENVIRONMENTvalue.Impact
Entrypoint and gateway logs can now correlate a synchronous request with the same ID. Structured records identify the correct service and deployed Entrypoint environment. Authentication, routing, secrets, workflows, API schemas, generated clients, and asynchronous job semantics are unchanged.
Tests
git diff --check: passedReal Modal integration smoke tests were not run because they create ephemeral deployments; the hermetic Modal image-definition and import-smoke tests passed in the gateway and executor unit suites.