Route API v1 simulations through the Stage 5 entrypoint - #3776
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3776 +/- ##
==========================================
+ Coverage 80.03% 80.71% +0.67%
==========================================
Files 70 74 +4
Lines 4342 4422 +80
Branches 809 822 +13
==========================================
+ Hits 3475 3569 +94
+ Misses 648 623 -25
- Partials 219 230 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
anth-volk
marked this pull request as ready for review
July 29, 2026 16:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SimulationAPIClientand retain compatibility aliases for the former Modal-specific client;SIM_ENTRYPOINT=old_gateway_direct;Why
API v1 needs to adopt the separate Stage 5 simulation service boundary without coupling that code change to the eventual routing switch. Keeping both targets selectable allows the new client and deployment machinery to be qualified while API v1 continues to call the existing Modal gateway directly.
Every qualified API v1 release should still become the stable Cloud Run API release without an operator-run traffic ramp. The deployment workflow therefore promotes the exact tested API revision automatically, while the later simulation-path cutover remains a small Git change from
old_gateway_directtocloud_run_simulation_entrypoint.Impact
This PR does not change API v1's active simulation network path: staging and production are both Git-pinned to the direct old-gateway mode. It does change API v1's Cloud Run release process so that successful staging and production candidates automatically receive 100% of their service's stable traffic, with exact-revision verification and immediate rollback protection.
Existing imports remain available through explicit compatibility aliases. Both simulation URLs remain configured so a later, independently reviewed PR can flip the selector without another client refactor.
Root cause
The previous client and deployment configuration assumed that API v1 called the Modal-hosted gateway directly. The first rollout design then coupled the simulation routing choice to an operator-run percentage ramp and left API Cloud Run service promotion manual. That did not match the desired release model: fully qualify staging, deploy production automatically, promote the exact tested release, and make the eventual simulation entrypoint switch through Git.
Validation
{"status":"healthy"}from/healthand200 OKfrom/readiness-checkin a local runtime smoke test.git diff --checkpassed.LATEST/tag-based traffic promotion.Fixes #3775