Skip to content

make_hero.py: compute widest band per-quarter and describe lower edge from data - #138

Merged
vahid-ahmadi merged 1 commit into
mainfrom
fix-hero-desc-generator
Jul 29, 2026
Merged

make_hero.py: compute widest band per-quarter and describe lower edge from data#138
vahid-ahmadi merged 1 commit into
mainfrom
fix-hero-desc-generator

Conversation

@vahid-ahmadi

Copy link
Copy Markdown
Contributor

Fixes the CI failure "validation/index.html matches its sources" from #137: assets/make_hero.py regenerates the hero desc, so the hand-corrected text diverged. The generator itself had the bugs — it now computes the widest 90% band per-quarter and describes the lower-edge sign from the data. make_hero.py --check passes.

🤖 Generated with Claude Code

… from data

The desc previously labeled the widest quarter by min lower edge and
spliced min(lo90)/max(hi90) from different quarters; it also asserted
the lower edge stays below zero regardless of the data.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
macromod Building Building Preview Jul 29, 2026 3:52pm

Request Review

@vahid-ahmadi
vahid-ahmadi merged commit 690046c into main Jul 29, 2026
4 checks passed
@vahid-ahmadi
vahid-ahmadi deleted the fix-hero-desc-generator branch July 29, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant