E8-S03: PublicNetwork CRD and observe-only controller - #32
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…ntinel E8-S03 - Add var errObserveOnly sentinel in both cluster and namespaced controllers - Update Create/Update to return the sentinel (enables errors.Is assertions) - Remove dead errNoPublicNetwork constant from cluster controller - Rename controller_test.go -> publicnetwork_test.go in cluster package - Add publicnetwork_test.go to namespaced package (was missing) - Fix import grouping in test files (stdlib / k8s / PlatformRelay) - All tests use errors.Is(err, errObserveOnly) for precise assertions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gate results
All gates pass: go build, go vet, unit tests (5 cases), CRD YAML gate script
Note on zz_generated files
zz_generated.managed.go, zz_generated.managedlist.go, and zz_generated.deepcopy.go regenerated via angryjet + controller-gen to include PublicNetwork. These match make generate output.