chore(timer): split inline tests out of timer.rs after #8328 - #8355
Merged
Conversation
#8328 pushed timer.rs to 2001 lines, one over the check_file_size.sh cap. Move the trailing #[cfg(test)] block to timer/tests_inline.rs behind a #[path] mod, following the box/release_tests.rs precedent, and re-export it so the helpers other modules reach as crate::timer::* still resolve.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe inline timer test helpers and tests moved from ChangesTimer test extraction
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#8328 landed from a fork branch that pushed
crates/perry-runtime/src/timer.rsto2001 lines, one over the 2000-line cap in
scripts/check_file_size.sh. I couldnot push to the fork, so this applies the split immediately after the merge rather
than bouncing an otherwise-green PR over one line.
Changes
#[cfg(test)]block (234 lines) tocrates/perry-runtime/src/timer/tests_inline.rsbehind a#[path]+moddeclaration, following the
box/release_tests.rsprecedent from fix(runtime): release closure-visible async boxes #8303.#[cfg(test)]: several helpers are reached from othermodules as
crate::timer::test_clear_timer_scanner_rootsand friends, so thebare extraction broke nine call sites. The re-export restores the original
paths.
Validation
scripts/check_file_size.sh— exit 0 (timer.rs now 1775 lines)cargo test -p perry-runtime --lib— 2585 passed, 0 failed, the same countas before the split, so no test was dropped by the move
cargo fmt --allSummary by CodeRabbit
Tests
Chores