docs(gc-handoff): final probe count for #7803, and how to rebuild the experiment - #7992
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Zod GC handoff notes now report 12 successful phase-probe runs and explain the missing seed-11 log. They also document a complete rebuild and reproduction procedure, including the 16-seed fuzz sweep and diagnostic requirements. ChangesZod GC handoff documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7989, which merged while the last two background sweeps were still
running. Doc-only, same file.
10 of 10 recorded at merge time. Seed 11's marker log reads empty only because
a disk-pressure cleanup of mine deleted its stderr while that run was still in
flight — recorded rather than quietly dropped.
CARGO_TARGET_DIRwere both deleted by whatever sweeps/Users/amlug/projects/perry/wt-*on this box, while a sweep was stillrunning, so the next person gets no artifacts — only the recipe. It includes
the one non-obvious requirement:
PERRY_NO_AUTO_OPTIMIZE=1is not optional,because the auto-optimizer relinks the runtime without
diagnosticsandremoves the
[gc-fromspace-protect]evidence the analysis depends on.No version bump.
Summary by CodeRabbit