Skip to content

chore(gc): split barrier.rs at the 2000-line cap - #7863

Merged
proggeramlug merged 4 commits into
mainfrom
fix/barrier-file-size
Aug 11, 2026
Merged

chore(gc): split barrier.rs at the 2000-line cap#7863
proggeramlug merged 4 commits into
mainfrom
fix/barrier-file-size

Conversation

@proggeramlug

Copy link
Copy Markdown
Contributor

The evening merge round pushed gc/barrier.rs to 2,157 lines, going red on the file-size gate. Same remedy as #7830: the remembered-set inspection/drain/clear group (229 lines) moves to gc/barrier/maintenance.rs as a sibling module with explicit re-export — no logic change, verified by the full runtime suite (2,118 green single-threaded), the barrier-filtered suite, fmt, the file-size gate (green again), the thread-local policy gate (two cold entries re-keyed to the new path via --update, diff is pure rename), the root-holders gate, and the full local lint gate 19/19.

One resolution note: the moved group's pub(super) items widen to pub(in crate::gc) because a re-export cannot widen visibility — the reachable set is unchanged (same consumers in gc/cycle.rs and gc/fromspace_scan.rs that could already see them when barrier was a flat file).

Ralph Küpper added 4 commits August 11, 2026 17:32
…s to a sibling module

barrier.rs reached 2,157 lines after the 2026-08-11 evening merges. The
remembered-set inspection/drain/clear group moves to barrier/maintenance.rs
(the #7830 recipe: cohesive group, explicit re-export, no logic change);
tail visibilities widen one module level (pub(super) -> pub(in crate::gc))
because the re-export cannot widen them.

Claude-Session: https://claude.ai/code/session_01Y1QZ5wUP9gRSwpiweT4Wix
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proggeramlug, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6ec56b30-27fb-4983-8479-c11e77d25b46

📥 Commits

Reviewing files that changed from the base of the PR and between 06ab783 and b34e430.

📒 Files selected for processing (4)
  • changelog.d/7863-barrier-file-split.md
  • crates/perry-runtime/src/gc/barrier/maintenance.rs
  • crates/perry-runtime/src/gc/barrier/mod.rs
  • scripts/thread_local_cold_allowlist.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug
proggeramlug merged commit c037702 into main Aug 11, 2026
1 of 19 checks passed
@proggeramlug
proggeramlug deleted the fix/barrier-file-size branch August 11, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant