Replace navigateLean with getWithChildren for the timeline view - #1138
Open
aasandei-vsp wants to merge 3 commits into
Open
Replace navigateLean with getWithChildren for the timeline view#1138aasandei-vsp wants to merge 3 commits into
aasandei-vsp wants to merge 3 commits into
Conversation
aasandei-vsp
marked this pull request as draft
August 17, 2026 12:31
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## PER-10679-replace-navigate-lean-publish #1138 +/- ##
===========================================================================
- Coverage 52.83% 52.16% -0.67%
===========================================================================
Files 355 360 +5
Lines 12154 12542 +388
Branches 2206 2274 +68
===========================================================================
+ Hits 6422 6543 +121
- Misses 5504 5764 +260
- Partials 228 235 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aasandei-vsp
force-pushed
the
PER-10677-replace-navigate-lean-timeline
branch
from
August 21, 2026 10:49
229dc80 to
ac8d6e8
Compare
aasandei-vsp
force-pushed
the
PER-10679-replace-navigate-lean-publish
branch
2 times, most recently
from
August 21, 2026 11:30
01eddfb to
f22d6d7
Compare
aasandei-vsp
force-pushed
the
PER-10677-replace-navigate-lean-timeline
branch
from
August 21, 2026 11:41
ac8d6e8 to
8aeaf3b
Compare
aasandei-vsp
marked this pull request as ready for review
August 21, 2026 11:43
aasandei-vsp
force-pushed
the
PER-10677-replace-navigate-lean-timeline
branch
from
August 21, 2026 11:52
8aeaf3b to
28badda
Compare
aasandei-vsp
force-pushed
the
PER-10679-replace-navigate-lean-publish
branch
from
August 21, 2026 11:59
f22d6d7 to
476f085
Compare
aasandei-vsp
force-pushed
the
PER-10677-replace-navigate-lean-timeline
branch
from
August 21, 2026 12:01
28badda to
99b406c
Compare
In order for the migration of the timeline to be complete, we needed to map some extra fields to stela: folderLinkIds, archiveNumbers, accessRole. And for deep links, we needed to be able to get folders using the properties mentioned above, so we needed an extra call to the old API, because if the user is deep in a folder and uses the browser refresh, the only way to identity the folder you were in, would be using the archiveNbr and the folder_linkId, which is not possible using the stela endpoints. Issue: PER-10677
Lean folder response uses now getWithChildren instead of navigateLean and returns consistently a promise, no observable. Stela rejects with a raw http error, which is different from the old backend, so a specific error message handler was needed. Issue: PER-10677
The timeline folder navigation, going into a folder used the navigateLean endpoint, so we replaced it with getWithChildren. The fact that we are making a BE call from a component that otherwise does not have this kind of logic is counterintuitive, but the needed refactoring to extract this logic is out of scope for the current work and it would need testing many other places. Issue: PER-10677
aasandei-vsp
force-pushed
the
PER-10677-replace-navigate-lean-timeline
branch
from
August 21, 2026 13:24
99b406c to
3bae6b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Do not merge before #1135 , this PR depends on the mappings from that specific PR
Depends on accessRole being on stela records and folders
Manual test cases — timeline view moved from navigateLean to getWithChildren
Note
The timeline folder tiles no longer show an
N itemscount. That is expected — Stela'sfolder payload has no record-count field. The tile renders without the count line rather
than showing zero.
Timeline navigation ⭐
Scenario — loading the timeline
Scenario — clicking a folder in the timeline
Scenario — clicking a breadcrumb
change. It does not just zoom or refit in place.
Scenario — deep link
/app/private/view/timeline/{archiveNbr}/{folderLinkId}and open it in a fresh tab.
Permissions ⭐
(run as both the owner and the Viewer account — the point is that the two differ)
Stela reports the caller's role as
owner/viewer, which this PR translates intoaccess.role.owner/access.role.viewer. Untranslated, every gate denied.Scenario — owner keeps their actions
Scenario — viewer is still restricted
Breadcrumbs outside the timeline
Scenario — unlisted share breadcrumbs
nullorundefinedsegment such as/private/null/194781.Shared record via share preview
Scenario — open a shared record
Error handling
Scenario — deep link to a folder that does not exist
folderLinkIdand load it./private. Previouslythis threw a
TypeErrorinside the error handler, because the deep-link target has notypeto call.includes('root')on.