Implement create match between two members for a match cycle - #78
Implement create match between two members for a match cycle#78rootandroo wants to merge 1 commit into
Conversation
rootandroo
commented
Aug 14, 2026
rootandroo
commented
- create controller for creating a match between two members
- create service for an admin to create a match between two members
- create DTOs for responses and requests
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
63b3fe2 to
b09b563
Compare
|
❌ The last analysis has failed. |
adb4bd4 to
3df3274
Compare
- create controller for creating a match between two members - create service for an admin to create a match between two members - create DTOs for responses and requests
3df3274 to
b63a2c8
Compare
b09b563 to
432f005
Compare
|
There was a problem hiding this comment.
Lets just stick with MatchController for everything, and then we can handle the permissioning after the fact, once Randy's done.
There was a problem hiding this comment.
Please keep requests and response names synced, even if you have to repeat them.
I know it's kinda annoying and verbose, but it should be ->
CreateMatchCycleRequest
CreateMatchCycleResponse
I personally like having protobuf files to condense all of these DTOs into one file, but that's more infra to set up.
There was a problem hiding this comment.
Lets drop everything related to feedback.
2 participants
