Skip to content

Remove unmatched_ids from match_cycles schema #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rootandroo merged 1 commit into from
Aug 14, 2026
Merged

Remove unmatched_ids from match_cycles schema #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion db/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ erDiagram
timestamptz run_at "{NOT_NULL}"
integer total_members
integer total_matched
integer[] unmatched_id
}

matches {
Expand Down
1 change: 1 addition & 0 deletions db/migration/V0005__Drop_unmatched_id_from_match_cycles.sql
View file
Open in desktop
Comment thread
rootandroo marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ALTER TABLE "match_cycles" DROP COLUMN "unmatched_id";
5 changes: 0 additions & 5 deletions src/main/java/org/patinanetwork/patchats/api/match/db/models/MatchCycle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package org.patinanetwork.patchats.api.match.db.models;

import java.time.Instant;
import java.util.List;
import java.util.UUID;
import lombok.Builder;
import lombok.EqualsAndHashCode;
import lombok.Getter;
Expand All @@ -28,7 +26,4 @@ public class MatchCycle {

@Setter
private Integer totalMatched;

@Setter
private List<UUID> unmatchedIds;
}
2 changes: 0 additions & 2 deletions src/main/java/org/patinanetwork/patchats/api/match/db/repos/MatchCycleRepo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ public interface MatchCycleRepo {
* <li>period
* <li>totalMembers
* <li>totalMatched
* <li>unmatchedIds
* </ul>
* The id field will be auto-generated by the database.
*/
Expand All @@ -31,7 +30,6 @@ public interface MatchCycleRepo {
* <li>runAt
* <li>totalMembers
* <li>totalMatched
* <li>unmatchedIds
* </ul>
*/
Optional<MatchCycle> updateMatchCycle(MatchCycle matchCycle);
Expand Down
3 changes: 0 additions & 3 deletions src/main/java/org/patinanetwork/patchats/api/match/design.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ public class MatchCycleResponse {
private Instant runAt;
private Integer totalMembers;
private Integer totalMatched;
private List<String> unmatchedIds; // UUIDs
}

// admin detail — cycle + filtered matches
Expand All @@ -70,7 +69,6 @@ public class CreateMatchCycleRequest {
private String period; // optional
private Integer totalMembers;
private Integer totalMatched;
private List<String> unmatchedIds;
}

// PATCH /api/admin/match_cycles/{id}
Expand All @@ -79,7 +77,6 @@ public class UpdateMatchCycleRequest {
private String period;
private Integer totalMembers;
private Integer totalMatched;
private List<String> unmatchedIds;
}

// GET /api/admin/match_cycles (query params)
Expand Down
Loading