🌟 [Major]: Template greeting command removed from module API#17
Draft
Marius Storhaug (MariusStorhaug) wants to merge 2 commits into
Draft
🌟 [Major]: Template greeting command removed from module API#17Marius Storhaug (MariusStorhaug) wants to merge 2 commits into
Marius Storhaug (MariusStorhaug) wants to merge 2 commits into
Conversation
Canonical public help link validation now lives in Process-PSModule. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
No Significant Changes DetectedThis PR does not contain changes to files that would trigger a new release:
Build, test, and publish stages will be skipped for this PR. If you believe this is incorrect, please verify that your changes are in the correct locations. |
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
Domeneshop now exposes only commands backed by its real API functionality. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Domeneshop now exposes only commands backed by Domeneshop functionality. The generic template greeting command is removed, and canonical public help link validation moves to the shared Process-PSModule pipeline without changing the remaining links.
Breaking Changes
Get-PSModuleTestis no longer exported by Domeneshop. Callers using this template command must remove that usage; there is no replacement because the command did not provide Domeneshop functionality.Changed: Public help link validation is shared
The remaining public command help links continue to use their canonical
https://psmodule.io/Domeneshop/Functions/...destinations. Validation will be supplied centrally by PSModule/Process-PSModule#420 at final commitc434b4505583b3a7a223ff3694d9ef5d42f7d03a.Important
This pull request depends on PSModule/Process-PSModule#420 at
c434b4505583b3a7a223ff3694d9ef5d42f7d03aand must not merge until Domeneshop consumes a Process-PSModule release containing that change, so the centralized validation is active.Technical details
src/functions/public/Get-PSModuleTest.ps1and its dedicated test because they are template boilerplate rather than Domeneshop functionality.tests/PublicHelpLinks.Tests.ps1repository-local test.c434b4505583b3a7a223ff3694d9ef5d42f7d03a.Relevant issues (or links)