More mappings for 1.13 snapshots#213
Conversation
SpaceWalkerRS
left a comment
SpaceWalkerRS
left a comment
There was a problem hiding this comment.
I think I got about halfway through the changes, I'll do the rest tomorrow
| p 1 p_1 | ||
| p 2 p_2 | ||
| c net/minecraft/unmapped/C_66796240$C_53134182$53458528 53458528 | ||
| c net/minecraft/unmapped/C_66796240$C_53134182$53458528 53458528 |
There was a problem hiding this comment.
what on earth happened here, I guess it doesn't break anything but it's weird this extra tab got inserted
There was a problem hiding this comment.
enigma weirdly inserted atComparator locally, so I pasted original values through text editor and probably caught that when selecting
| p 1 state | ||
| p 2 ctx | ||
| m (Lnet/minecraft/unmapped/C_15815210;Lnet/minecraft/unmapped/C_46108969;Lnet/minecraft/unmapped/C_32594356;Lnet/minecraft/unmapped/C_28786548;)Z m_95670435 shouldNotRender | ||
| m (Lnet/minecraft/unmapped/C_15815210;Lnet/minecraft/unmapped/C_46108969;Lnet/minecraft/unmapped/C_32594356;Lnet/minecraft/unmapped/C_28786548;)Z m_95670435 shouldRenderFace |
There was a problem hiding this comment.
this is suspicious, I suppose the function of the method got inverted?
There was a problem hiding this comment.
not sure why was it even called this way, it has same behavior as Block#shouldRenderFace in version prior. that is, deciding whether the face should be rendered. perhaps, changed behavior in later versions?
2 participants
No description provided.