visual-test label step fails; cascades skip screenshot. - #979
Open
opencode-agent[bot] wants to merge 1 commit into
Open
visual-test label step fails; cascades skip screenshot.#979opencode-agent[bot] wants to merge 1 commit into
opencode-agent[bot] wants to merge 1 commit into
Conversation
Contributor
|
User opencode-agent[bot] does not have write permissions |
Contributor
kcov coverageLine coverage ran for this PR and uploaded a non-blocking report artifact named |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue filed: #978 (label
visual-test).Key finding: The workflow doesn't fail in the rendering code at all. Step 8 "Ensure visual-test label exists" in
.github/workflows/visual-test.yml:55-69exits non‑zero in ~2s on every run since #977. That cascades into skipping the Lavapipe setup, the screenshot run, and artifact upload — which is whybuild-output.logandscreenshot.pngare missing from this workspace. The other opencode workflows (opencode-audit.yml,opencode-test-writer.yml) already route this throughscripts/ensure_label.sh, which degrades label‑create failures to a warning;visual-test.ymlshould do the same.The issue also flags two docs drifts I noticed while cross‑reading the prompt: the diagnosis prompt still describes a PPM → PNG path, but the workflow emits PNG directly and
modules/engine-graphics/src/vulkan/screenshot.zigonly supports PNG/JPEG/GIF/WebP, and the screenshot gate atsrc/game/app.zig:556requiresscreenshot_settle_frames >= 30independent ofZIGCRAFT_SMOKE_FRAMES.Triggered by scheduled workflow
opencode session | github run