Skip to content

visual-test label step fails; cascades skip screenshot. - #979

Open
opencode-agent[bot] wants to merge 1 commit into
devfrom
opencode/schedule-6f2b5f-20260811054508
Open

visual-test label step fails; cascades skip screenshot.#979
opencode-agent[bot] wants to merge 1 commit into
devfrom
opencode/schedule-6f2b5f-20260811054508

Conversation

@opencode-agent

Copy link
Copy Markdown
Contributor

Issue filed: #978 (label visual-test).

Key finding: The workflow doesn't fail in the rendering code at all. Step 8 "Ensure visual-test label exists" in .github/workflows/visual-test.yml:55-69 exits non‑zero in ~2s on every run since #977. That cascades into skipping the Lavapipe setup, the screenshot run, and artifact upload — which is why build-output.log and screenshot.png are missing from this workspace. The other opencode workflows (opencode-audit.yml, opencode-test-writer.yml) already route this through scripts/ensure_label.sh, which degrades label‑create failures to a warning; visual-test.yml should do the same.

The issue also flags two docs drifts I noticed while cross‑reading the prompt: the diagnosis prompt still describes a PPM → PNG path, but the workflow emits PNG directly and modules/engine-graphics/src/vulkan/screenshot.zig only supports PNG/JPEG/GIF/WebP, and the screenshot gate at src/game/app.zig:556 requires screenshot_settle_frames >= 30 independent of ZIGCRAFT_SMOKE_FRAMES.

Triggered by scheduled workflow

New%20session%20-%202026-08-11T05%3A45%3A07.939Z
opencode session  |  github run

@github-actions github-actions Bot added documentation Improvements or additions to documentation build labels Aug 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

User opencode-agent[bot] does not have write permissions

github run

@github-actions

Copy link
Copy Markdown
Contributor

kcov coverage

Line coverage ran for this PR and uploaded a non-blocking report artifact named kcov-report. Codecov upload is configured as non-blocking while the project captures a stable baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants