Remove the Windows-era scripts the droplet made dead - #21
Merged
Conversation
Six files from when the server ran locally on Windows. None can work
against a Linux droplet, none are referenced by CI, and most only
referenced each other:
backup_server.ps1 zips $PSScriptRoot\data; the droplet has
DigitalOcean snapshots and deploy-time backups
register_backup_policy.ps1 hardcodes F:\minecraft\ and registers a
Windows scheduled task
stop_server.ps1 local Windows shutdown wrapper
register_playtime_policy.ps1 Windows scheduled task
playtime_limit.ps1 see below
server_commands.txt a UTF-16 dump of vanilla command help from a
NEWER Minecraft than we run: it lists /dialog and
locator_bar, which do not exist in 1.20.1
Kept sync_guide_to_mrpack.ps1. It is Windows-only too, but it solves a live
problem rather than a dead one: Patchouli can only tell a client which book
to open, so the client needs the book JSON already in its pack, and forgetting
that step is why /guide silently does nothing for players on a stale pack.
tools/sync_client_pack.py handles mods, not the guide overrides, so the two are
complementary. Pack edits happen on the Windows machine anyway.
The one deletion that costs something is playtime_limit.ps1. It capped each
kid at 120 minutes a day by pulling them off the whitelist, which
ENFORCE_WHITELIST turned into an instant kick, and restored them at the day
rollover. It has not run since the move to the droplet, so that control has
silently been off for weeks.
DEPLOY.md now says so in plain terms rather than describing it as a feature
that merely needs porting. A parental control that is documented as existing
but is not running is worse than one that is honestly marked absent, because
someone is relying on it. The logic remains in git history if it is wanted as
a starting point for a Linux version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup of the root directory. Six files from when the server ran locally on Windows.
Deleted
backup_server.ps1$PSScriptRoot\dataon Windows. Droplet has DO snapshots + deploy-time backupsregister_backup_policy.ps1F:\minecraft\, registers a Windows scheduled task. Unreferencedstop_server.ps1register_playtime_policy.ps1playtime_limit.ps1server_commands.txt/dialogandlocator_bar, which do not exist in 1.20.1None are referenced by CI. Verified before deleting.
Kept: sync_guide_to_mrpack.ps1
Windows-only as well, but it solves a live problem rather than a dead one. Patchouli can only tell a client which book to open; the client must already have the book JSON in its pack. Forgetting that step is why
/guidesilently does nothing for players on a stale pack.tools/sync_client_pack.pyhandles mods, not the guide overrides, so the two are complementary. Pack edits happen on the Windows machine anyway.The deletion that actually costs something
playtime_limit.ps1capped each kid at 120 minutes a day by removing them from the whitelist, whichENFORCE_WHITELISTturned into an instant kick, then restored them at the day rollover.It has not run since the move to the droplet, so that control has silently been off for weeks.
DEPLOY.mdpreviously described it as merely "Windows-only, a Linux version isn not written yet". It now says plainly that there is currently no time limit of any kind, with what a Linux version would need.A parental control documented as existing but not running is worse than one honestly marked absent, because someone is relying on it. The logic stays in git history if you want it ported.
Verified
Root goes from 13 files to 7.