fix(security): cap client recv budgets and default FFI max_connections#90
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(security): cap client recv budgets and default FFI max_connections#90cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
- Add per-poll and per-command-wait byte caps on the RTMP client recv path so a malicious server cannot monopolize the embedder thread or force hundreds of megabytes through the AMF connect handshake. - Apply DEFAULT_FFI_MAX_CONNECTIONS (256) when lrtmp2_server_create receives a zero-initialized ServerConfig, preserving unlimited semantics for the idiomatic Rust Server::new API. Co-authored-by: Alexander Wagner <info@alexanderwagnerdev.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| let server = unsafe { lrtmp2_server_create(&config) }; | ||
| assert!(!server.is_null()); | ||
| unsafe { | ||
| let s = &*server; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security review fixes
Scheduled scan found two new medium-severity issues; this PR remediates both.
1. Client recv paths lack per-call byte budgets (Medium) —
src/client/mod.rsClient::poll()or force up to ~256 MiB through the AMF connect handshake (wait_for_command× 64 max-size messages).MAX_RECV_BYTES_PER_POLL(256 KiB) andMAX_RECV_BYTES_PER_COMMAND_WAIT(256 KiB) caps mirroring the server-side fairness limits.2. Zero-initialized FFI ServerConfig disables connection limits (Medium) —
src/lib.rscalloc/{0}forServerConfiggetmax_connections == 0, which disables all connection limiting and enables trivial memory-exhaustion DoS.lrtmp2_server_createsubstitutesDEFAULT_FFI_MAX_CONNECTIONS(256) whenmax_connections <= 0; idiomatic RustServer::newbehavior is unchanged.Tests
max_connectionsenforcement testcargo test --no-default-featurespasses.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.