Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typecheck tests/ in npm run check tests/ was in no tsconfig include path, so
npm run checknever looked at it. Vitest transpiles without typechecking, so a greennpm testsaid nothing about whether the specs were type-correct — two type errors sat in tests/memory-leak.test.ts undetected until the previous commit. Adds tsconfig.tests.json, mirroring the existing tsconfig.scripts.json pattern: extends the root config and addsnodetypes forprocessandglobalThis.gc. Kept as a separate program rather than widening the root include so node types do not leak into the src build. Verified by planting a deliberate type error in tests/setup.ts and confirmingnpm run checkfails on it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011gaCkV6CD5uR1SJpq3BPss #103New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Typecheck tests/ in npm run check tests/ was in no tsconfig include path, so
npm run checknever looked at it. Vitest transpiles without typechecking, so a greennpm testsaid nothing about whether the specs were type-correct — two type errors sat in tests/memory-leak.test.ts undetected until the previous commit. Adds tsconfig.tests.json, mirroring the existing tsconfig.scripts.json pattern: extends the root config and addsnodetypes forprocessandglobalThis.gc. Kept as a separate program rather than widening the root include so node types do not leak into the src build. Verified by planting a deliberate type error in tests/setup.ts and confirmingnpm run checkfails on it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011gaCkV6CD5uR1SJpq3BPss #103Changes from all commits
dbc9fbd701bd68554108dc706d54File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.