Hoist shared constants and dedupe control icons - #102
Merged
Conversation
Move cross-file layout, resize-handle, control-icon, and decimal-place constants into TrackLabConstants; share axes/calibration/magnifier/tracking glyphs via TrackLabIcons; drop unused spacing constants; and align MAX_TRACKS docs with the runtime cap of 4.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
veillette
marked this pull request as ready for review
July 23, 2026 19:32
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewed the codebase against the fleet
scenerystack-constantsguidance and hoisted values that were duplicated across files intoTrackLabConstants.ts.Hoisted
SCREEN_TOP_MARGIN,VIDEO_PLAYER_LEFT_SPACING,KINEMATICS_GRAPH_BOTTOM_MARGIN(join the other screen offsets already inTrackLabConstants)DataTableNodeandResizeGestureHandlerControlPanelandInfoDialogNodeDATA_DECIMAL_PLACESfor table cells and CSV exportPanGestureHandlernow usesOVERLAY_DRAG_SPEED+ newGRAPH_PAN_SHIFT_DRAG_SPEEDRelated cleanup
TrackLabIconsTRACK_LIST_LEFT_SPACINGandPANEL_HEADER_HEIGHTCLAUDE.mdthat claimed 26 concurrent tracks; runtime cap isMAX_TRACKS = 4(A–Z palette remains)Left local (by design)
File-scoped visual constants (tape/angle endpoints, graph tick fonts, webcam modal radius, OpenCV thresholds, coordinate-system drag speeds) stay at the top of their single consumer.
Verification
npm run check— passnpm test— 7/7 passnpm run lint— pass (pre-existing nursery warnings in tests only)