Fix job writing guide: update examples to current adaptor APIs

[hunterachieng]

Short Description

Updated all code examples in the job writing guide to reflect the current adaptor API. Removed legacy v1 helpers (fields, dataValue, relationship, bulk, etc.) in favour of plain JavaScript objects and arrow functions, fixed deprecated 3-argument operation callbacks to use .then(), and corrected several syntax errors and typos across the guide.

Closes #788

Details

The approach was to go through each file in the job writing guide and compare every code example against the current adaptor docs (salesforce-docs.md, dhis2-docs.md, http-docs.md, openmrs-docs.md, etc.) to verify the APIs being demonstrated still exist and match the current signatures.

The main pattern shift is that v1 adaptors used a set of functional helpers (fields(), dataValue(), relationship()) to build operation arguments, whereas current adaptors accept plain JavaScript objects and arrow functions directly. Most examples needed to be rewritten around this, rather than just tweaked.

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to
know!):

• I have used Claude Code
• I have used another model
• I have not used AI

You can read more details in our
Responsible AI Policy

[mtuchi]

@hunterachieng can you also review all job examples or create a sub issue for it, I think we should try to clean up at least the top 5 adaptors

[hunterachieng]

@mtuchi I checked the adaptor examples and majority are up to date

[mtuchi]

@hunterachieng i meant job examples for each of our adaptor, we mantain couple of examples in our docs
Here are couple of links

• https://docs.openfn.org/adaptors/library/jobs/auto/async-and-array-dot-map
• https://docs.openfn.org/adaptors/library/jobs/auto/complex-http-request-chains
• https://docs.openfn.org/adaptors/library/jobs/auto/bring-formId-into-data-array-then-create-parent-and-children-in-salesforce
• https://docs.openfn.org/adaptors/library/jobs/auto/concatenate-many-fields-with-nulls

See this folder to see all our official job code library we mantain
https://github.com/OpenFn/docs/tree/main/adaptors/library/jobs

Most of these examples contain anti-patterns like writing nested operations, some are just using very old way of mapping

[mtuchi]

Can you move clean outside the fn block,
I update

 const clean = val =>
    val === null ? '' : val.toString().replace(/-/g, ' ');