Only allow coverage_attribute when running coverage#175
Merged
makubacki merged 1 commit intoJul 9, 2026
Conversation
Supplements the change made to narrow the set of unstable features allowed in commit 599797b by only allowing `coverage_attribute` when running coverage. Removes `coverage_attribute` from `allow-features` by default and only sets it when running coverage (`cargo make coverage`). This allows the feature where it is needed and catches any accidental usage of `#[coverage(off)]` where it is not gated on `cfg(coverage_nightly)`. Updates all Makefile.toml files that contain a coverage task that use cargo-llvm-cov. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Javagedes
approved these changes
Jul 9, 2026
apop5
approved these changes
Jul 9, 2026
cfernald
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supplements the change made to narrow the set of unstable features allowed in commit 599797b by only allowing
coverage_attributewhen running coverage.Removes
coverage_attributefromallow-featuresby default and only sets it when running coverage (cargo make coverage). This allows the feature where it is needed and catches any accidental usage of#[coverage(off)]where it is not gated oncfg(coverage_nightly).Updates all Makefile.toml files that contain a coverage task that use cargo-llvm-cov.