fix: keep tray command failures visible - #31
Merged
Conversation
abrichr
marked this pull request as ready for review
July 28, 2026 05:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
FalseIPC result as a failed command for stop, open, teach, pause, and resume actions.Why
Several tray paths discarded a failure result and then rendered a success-shaped state. A failed stop command could remain at
RECORDING_STOPPING. A failed pause command could reportSYNCED. An invalid count could clear the badge to zero. An unrelated sync update could also emitRecording Stopped.Validation
uv run --extra dev pytest tests -q— 208 passed, 2 skippeduv run --extra dev ruff check .uv build --wheel --out-dir /tmp/oa-tray-failure-sweep-distgit diff --check