fix(ci): repair cross-platform launch gates - #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root causes
tests/test_release_contract.pyimported Python 3.11'stomllibunconditionally. The same workflow's Playwright probe passed literal\"characters to Python; the command substitution raisedSyntaxError, but the enclosingechomasked the failure and produced an empty cache version.report.jsonwith a non-UTF-8 code page.Fix
tomlidependency on Python 3.10.tests/test_identity_ladder.py::test_harness_zero_false_accept_all_configson macOS; preserve the complete suite on every Ubuntu matrix leg and every other macOS test.PYTHONUTF8=1andPYTHONIOENCODING=utf-8for the clean-machine job and every lifecycle child process, decode captured output explicitly as UTF-8, and make run-report persistence/readers explicitly UTF-8.Verification
87 passedacross release/workflow/lifecycle/report/hosted/teach focused tests on Python 3.12.8 passedfor release and workflow contracts on Python 3.10.9.version=1.57.0locally.git diff --checkpasses.This PR does not change macOS, Windows, or RDP backend behavior and does not weaken the fail-closed product safety gates.