Added setting to horizontally offset start button - #2524
Open
hxmid wants to merge 2 commits into
Open
Conversation
ge0rdi
requested changes
Aug 27, 2026
| IDS_MENU_GLASS "Enable Aero Glass (requires Aero Glass mod)" | ||
| IDS_MENU_GLASS_TIP "Check this to use glass transparency (requires the Aero Glass mod to be installed)" | ||
| IDS_MAIN_MENU_SETTINGS "Main Menu" | ||
| IDS_BUTTON_OFFSET "Button left offset" |
Member
There was a problem hiding this comment.
I'd name it just Button offset.
The tooltip explains what kind of offset it means.
|
|
||
| virtual ULONG STDMETHODCALLTYPE AddRef( void ) | ||
| { | ||
| virtual ULONG STDMETHODCALLTYPE AddRef( void ) |
Member
There was a problem hiding this comment.
Can you remove these unintentional whitespace changes? They are not related to changes in this PR.
There are some more below.
| if (GetStartButtonType() == START_BUTTON_AERO) | ||
| x += ScaleForDpi(taskBar->taskBar, 6); | ||
| // we should also be able to shift our custom icon, as it's also incorrectly aligned to the left edge on Windows 11 | ||
| else if (GetStartButtonType() == START_BUTTON_CUSTOM) |
Member
There was a problem hiding this comment.
Note that this code is restricted only for Win11 without ExplorerPatcher.
I guess the offset setting should be more generic.
I'd move this outside of the if section.
By default the offset is 0 so it won't affect anything.
If user changes the setting, it would apply no matter of OS and other things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows 11 (at least on my PC) forces the start button to be locked to the left edge of the taskbar. These changes allow the horizontal offset to be adjusted, thus allowing it to correctly be placed overtop the start button.
before (offset 0):
after (offset 12):
Having a setting within the UI allows the user to have finer control where images/icons may not be perfectly aligned by default.