Skip to content

build: stop recording npm registry URLs in lockfiles - #447

Open
Jamie Magee (JamieMagee) wants to merge 1 commit into
OfficeDev:mainfrom
JamieMagee:fix/omit-lockfile-registry-resolved
Open

build: stop recording npm registry URLs in lockfiles#447
Jamie Magee (JamieMagee) wants to merge 1 commit into
OfficeDev:mainfrom
JamieMagee:fix/omit-lockfile-registry-resolved

Conversation

@JamieMagee

Copy link
Copy Markdown

Summary

  • Add omit-lockfile-registry-resolved=true in generate-docs and generate-docs/scripts.
  • Remove registry resolved fields from both lockfiles.
  • Keep lockfile version 3 and all other dependency metadata unchanged.

Validation

  • npm config get omit-lockfile-registry-resolved returned true in both project roots.
  • A second remediation pass made no lockfile changes.
  • Both lockfiles no longer contain Azure Artifacts feed URLs.
  • npm ci completed in both project roots with Node.js 24.19.0 and npm 11.19.0.
  • npm ls --all passed in generate-docs, and the API Extractor and API Documenter CLIs loaded successfully.
  • npm run build passed in generate-docs/scripts.
  • A clean npm run lint is blocked because eslint.config.mjs imports undeclared @eslint/js. With a temporary no-save install, lint completed with 0 errors and 2 existing warnings.

Add npm's omit-lockfile-registry-resolved setting to both documentation projects and remove registry URLs without changing dependency metadata.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@learn-build-service-prod

Copy link
Copy Markdown

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod

Copy link
Copy Markdown

Learn Build status updates of commit 0722006:

✅ Validation status: passed

File Status Preview URL Details
generate-docs/.npmrc ✅Succeeded
generate-docs/package-lock.json ✅Succeeded
generate-docs/scripts/.npmrc ✅Succeeded
generate-docs/scripts/package-lock.json ✅Succeeded

For more details, please refer to the build report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant